refactor: js-packages structure #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uandysmith
force-pushed
the
feature/playgrounds-refactor
branch
from
80033f9 to
b7e3956
Compare
CertainLach
reviewed
Jan 6, 2024
.github/workflows/xcm.yml
Outdated
| @@ -370,7 +370,7 @@ jobs: | |||
| - name: Call HRMP initialization | |||
| working-directory: js-packages/tests | |||
| run: | | |||
| yarn node --no-warnings=ExperimentalWarning --loader ts-node/esm util/createHrmp.ts ${{matrix.network}} | |||
| yarn node --no-warnings=ExperimentalWarning --loader ts-node/esm ../scripts/createHrmp.ts ${{matrix.network}} | |||
There was a problem hiding this comment.
Измени working-directory на js-packages/scripts
There was a problem hiding this comment.
Да, спасибо.
@CertainLach раз ты тут, то предлагаю сразу сливать, остальные правки лучше отдельно делать, без такой простыни диффов
There was a problem hiding this comment.
Мне не очень нравится дерево зависимостей новое, по идее от тестов то ничего не должно зависеть, а eth плейграунды стоит перенести в обычные плейграунды/отдельный пакет... Но ок
uandysmith
force-pushed
the
feature/playgrounds-refactor
branch
from
b7e3956 to
e4eea6c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.